Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Changes reverted in PR#1124 #1204

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Add: Changes reverted in PR#1124 #1204

merged 6 commits into from
Apr 19, 2024

Conversation

anshalshukla
Copy link
Contributor

@anshalshukla anshalshukla commented Mar 28, 2024 •
edited
Loading

Description

Adds changes back from the reverted PR#1124
Changes:

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@anshalshukla anshalshukla changed the base branch from master to v1.3.0-beta-candidate March 28, 2024 09:52
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.87500% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 51.44%. Comparing base (fd4b9c2) to head (3e113ed).

Files Patch % Lines
core/types/transaction_signing.go 0.00% 15 Missing ⚠️
core/txpool/legacypool/legacypool.go 25.00% 4 Missing and 2 partials ⚠️
params/config.go 0.00% 3 Missing ⚠️
eth/backend.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                  Coverage Diff                   @@
##           v1.3.0-beta-candidate    #1204   +/-   ##
======================================================
  Coverage                  51.44%   51.44%           
======================================================
  Files                        794      794           
  Lines                     131304   131315   +11     
======================================================
+ Hits                       67549    67558    +9     
+ Misses                     59576    59573    -3     
- Partials                    4179     4184    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshalshukla anshalshukla changed the title Consistent revert Add: Changes reverted in PR#1124 Mar 28, 2024
pratikspatil024 and others added 3 commits March 28, 2024 17:49
@pratikspatil024 @anshalshukla
test all default flags added via config file (#1105)
120cbc7
@anshalshukla
consensus/bor: handle blockalloc balance changes (#1074)
f506350 
* fix: set balance in blockalloc

* chg: don't update balance if not zero

* fix: lint

* fix logic, add test cases
@anshalshukla
fix: failure in milestones vote on hash
3e113ed
@anshalshukla anshalshukla requested a review from a team April 8, 2024 06:02
pratikspatil024
pratikspatil024 reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@pratikspatil024 pratikspatil024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base branch needs to be changed.

@anshalshukla anshalshukla changed the base branch from v1.3.0-beta-candidate to develop April 19, 2024 07:43
@anshalshukla anshalshukla requested review from pratikspatil024 and a team April 19, 2024 07:44
@anshalshukla anshalshukla merged commit 4a03cc0 into develop Apr 19, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xsharma 0xsharma 0xsharma approved these changes

@pratikspatil024 pratikspatil024 pratikspatil024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anshalshukla @0xsharma @pratikspatil024 @temaniarpit27